cmake: only add ui tools and their dependencies in toplevel build #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding gr-digitizers to a build using add_subdirectory or fetch_content, the targets for the ui tools and dependencies can clash. This commit removes them from the build if this project is not the too-level cmake project. Also default disables gr-digitizer tests in that case by default.
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
RalphSteinhagen
approved these changes
Jan 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding gr-digitizers to a build using add_subdirectory or fetch_content, the targets for the ui tools and dependencies can clash. This commit removes them from the build if this project is not the top-level cmake project.
Also default disables gr-digitizer tests in that case by default.
Longer term we should improve the cmake in all projects to allow overriding dependencies and correctly use cmake namespaces for the targets...